Skip to content

🌱 Build ironicclient using debian based python image#600

Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom
elfosardo:ironicclient-pythonbase
Jan 8, 2025
Merged

🌱 Build ironicclient using debian based python image#600
metal3-io-bot merged 1 commit intometal3-io:mainfrom
elfosardo:ironicclient-pythonbase

Conversation

@elfosardo
Copy link
Copy Markdown
Member

@elfosardo elfosardo commented Dec 5, 2024

This should reduce the size of the container from 340MB to 230MB

@elfosardo
Build ironicclient using debian based python image
ee2e7c5 
This should reduce the size of the container from 340MB to 230MB

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo
Copy link
Copy Markdown
Member Author

elfosardo commented Dec 5, 2024

/cc @dtantsur @Rozzii

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2024
@elfosardo elfosardo changed the title seedling: Build ironicclient using debian based python image 🌱 Build ironicclient using debian based python image Dec 5, 2024
tuminoid
tuminoid reviewed Dec 5, 2024
View reviewed changes
tuminoid
tuminoid reviewed Dec 5, 2024
View reviewed changes
@tuminoid
Copy link
Copy Markdown
Member

tuminoid commented Dec 5, 2024

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Dec 5, 2024

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

Details

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Dec 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
Rozzii
Rozzii reviewed Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@elfosardo
Copy link
Copy Markdown
Member Author

elfosardo commented Jan 7, 2025

@dtantsur please have a look when you get a chance, thanks

@dtantsur
Copy link
Copy Markdown
Member

dtantsur commented Jan 8, 2025

/approve

I hope you've checked that it works :)

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@metal3-io-bot metal3-io-bot merged commit 01a282a into metal3-io:main Jan 8, 2025
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Jan 8, 2025
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Apr 25, 2025
@openshift-merge-bot
Merge pull request metal3-io#600 from elfosardo/update-ironic-20241023
1e8aae2 
NO-ISSUE: Update ironic projects hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@zaneb zaneb Awaiting requested review from zaneb

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

ironic-image - v28.0

Development

Successfully merging this pull request may close these issues.

5 participants

@elfosardo @tuminoid @metal3-io-bot @dtantsur @Rozzii